-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-787: Course Level 2 style and clarity #1996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etail of the solutions explicit
✅ Deploy Preview for n8n-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@StarfallProjects I've finished out the tweaks to Chapters 5 and 6 that I could make without Bart's input. |
@freakwriter I have updated the quiz to correct the issues you found. |
@Joffcom thank you! |
StarfallProjects
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still finishing this up but I wanted to push a PR to get feedback on some things:
In Chapter 1:
I think people might be dropping from this course quickly because the first lessons here require you to write JS more or less from scratch with very little guidance on how to do it. I don't think we should be teaching folks how to write JS here, but I do wonder if we should just include some copy/paste-able scripts so that people don't get scared off from doing the exercises (which seem focused on getting you familiar with using the Code node). I didn't make major edits here because I wanted to get feedback on that approach--lmk what you think.
In Chapter 2:
And in Chapter 5:
We have a very brief appearance from Nathan to start this out, but in starting to work through the different subsections, it was a little unclear to me where some of the requirements were coming from. I suspect we should include more conversations with Nathan at the start of each of these sections so that the requirements do make more sense (more aligned with what the first course does); I just wanted to be sure that was an okay approach before I started doing it.
I have a little work in Chapter 5 and 6 remaining so this PR is not yet complete, mainly just wanted to share it to get feedback on some of the points above so I could put finishing touches on at the same time.